Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional 3rd static for PBE+U to MatPesStaticFlowMaker #606

Merged
merged 12 commits into from
Dec 4, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 11, 2023

The PBE+U static runs by default if the structure contains +U elements. Can be disabled by explicitly passing MatPesStaticFlowMaker(static3=None).

MatPesGGAPlusMetaGGAStaticMaker if structure contains +U elements
@janosh janosh added enhancement Improvements to existing features mp MP jobs/workflows vasp Vienna Ab initio Simulation Package labels Nov 11, 2023
@janosh janosh added the breaking Breaking changes label Nov 11, 2023
Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #606 (491aaab) into main (0c8eff8) will decrease coverage by 0.02%.
Report is 2 commits behind head on main.
The diff coverage is 78.57%.

❗ Current head 491aaab differs from pull request most recent head 9870600. Consider uploading reports for the commit 9870600 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   76.00%   75.98%   -0.02%     
==========================================
  Files          83       83              
  Lines        7027     7030       +3     
  Branches     1045     1046       +1     
==========================================
+ Hits         5341     5342       +1     
- Misses       1364     1365       +1     
- Partials      322      323       +1     
Files Coverage Δ
src/atomate2/common/utils.py 78.94% <ø> (ø)
src/atomate2/cp2k/schemas/task.py 82.56% <ø> (ø)
src/atomate2/vasp/flows/mp.py 89.36% <100.00%> (+1.36%) ⬆️
src/atomate2/vasp/sets/matpes.py 87.50% <100.00%> (+0.54%) ⬆️
src/atomate2/cli/dev.py 0.00% <0.00%> (ø)
src/atomate2/vasp/sets/base.py 74.18% <90.00%> (-0.20%) ⬇️
src/atomate2/vasp/flows/matpes.py 75.00% <66.66%> (-9.22%) ⬇️

@janosh janosh changed the title Add optional 3rd static for PBE+U to MatPesGGAPlusMetaGGAStaticMaker Add optional 3rd static for PBE+U to MatPesStaticFlowMaker Nov 12, 2023
@janosh janosh enabled auto-merge (squash) December 4, 2023 00:31
@janosh janosh merged commit ed459f4 into main Dec 4, 2023
6 checks passed
@janosh janosh deleted the matpes-flow-pbe+u-3rd-static branch December 4, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking changes enhancement Improvements to existing features mp MP jobs/workflows vasp Vienna Ab initio Simulation Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant