Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError: PhononBSPlotter.save_plot() got an unexpected keyword argument img_format #625

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 27, 2023

Following removal in materialsproject/pymatgen#3479. Was redundant with filename.

…argument 'img_format'

following removal in pymatgen, was redundant with filename
@janosh janosh added fix Bug fix PR phonon Phonon workflow related labels Nov 27, 2023
@janosh janosh enabled auto-merge (squash) November 27, 2023 01:54
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #625 (585f599) into main (9066774) will not change coverage.
The diff coverage is n/a.

❗ Current head 585f599 differs from pull request most recent head fff10ba. Consider uploading reports for the commit fff10ba to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   76.00%   76.00%           
=======================================
  Files          83       83           
  Lines        7027     7027           
  Branches     1045     1045           
=======================================
  Hits         5341     5341           
  Misses       1364     1364           
  Partials      322      322           
Files Coverage Δ
src/atomate2/common/schemas/phonons.py 97.14% <ø> (ø)

@janosh janosh merged commit 31ac8b2 into main Nov 27, 2023
6 checks passed
@janosh janosh deleted the fix-phonon-schema branch November 27, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR phonon Phonon workflow related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant