Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lobster mp workflow #634

Merged
merged 14 commits into from
Jan 26, 2024
Merged

Conversation

JaGeo
Copy link
Member

@JaGeo JaGeo commented Dec 5, 2023

Summary

This is an attempt to create an MP-compatible LOBSTER workflow.

  • Tests
  • Documentation

@JaGeo JaGeo changed the title Add lobster mp workflow WIP: Add lobster mp workflow Dec 5, 2023
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c3f126b) 76.25% compared to head (c095bd9) 76.17%.

❗ Current head c095bd9 differs from pull request most recent head 3a83e49. Consider uploading reports for the commit 3a83e49 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   76.25%   76.17%   -0.09%     
==========================================
  Files          87       87              
  Lines        7151     7164      +13     
  Branches     1057     1061       +4     
==========================================
+ Hits         5453     5457       +4     
- Misses       1374     1384      +10     
+ Partials      324      323       -1     
Files Coverage Δ
src/atomate2/lobster/schemas.py 91.59% <100.00%> (+0.44%) ⬆️
src/atomate2/vasp/flows/mp.py 88.33% <84.61%> (-1.03%) ⬇️

... and 2 files with indirect coverage changes

"IBRION": -1,
"ISMEAR": -5,
"LORBIT": 11,
# "ICHARG": 0, # is this okay?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to test both runs with and without structure optimization. There could be differences.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure will test these 😃

@JaGeo JaGeo changed the title WIP: Add lobster mp workflow Add lobster mp workflow Jan 26, 2024
@JaGeo
Copy link
Member Author

JaGeo commented Jan 26, 2024

@utf , @naik-aakash has now finished this PR. It is a LOBSTER workflow that is compatible with our LOBSTER database. This might also be useful for future integration of data into the MP. We would be happy about another review.

Copy link
Member

@utf utf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JaGeo and @naik-aakash. All looks good to me.

One question I had that could maybe be clarified in the docs: what do you mean by MP compatible settings - I see you're changing the pseudo potential version to PBE_54?

@JaGeo
Copy link
Member Author

JaGeo commented Jan 26, 2024

Thanks @JaGeo and @naik-aakash. All looks good to me.

One question I had that could maybe be clarified in the docs: what do you mean by MP compatible settings - I see you're changing the pseudo potential version to PBE_54?

Yes, you are right. We should maybe clarify that it is compatible with our Lobster database that will go into MP at some point.

docs/user/codes/vasp.md Outdated Show resolved Hide resolved
@utf utf merged commit 4e50400 into materialsproject:main Jan 26, 2024
6 checks passed
@utf
Copy link
Member

utf commented Jan 26, 2024

Thanks!

@utf utf added the feature A new feature being added label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature being added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants