Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prep for next pymatgen release #690

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Prep for next pymatgen release #690

merged 2 commits into from
Jan 26, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 26, 2024

Many pymatgen classes had inconsistently named get/from_(str|string) methods. get/from_string was deprecated in favor of get/from_str 6 months ago and removed last week in materialsproject/pymatgen#3561 which will be released this or next week.

@utf this change will require a new atomate2 version to be compatible with the upcoming pymatgen.

resulting AttributeError in current atomate2 reported by @abhardwaj73 in materialsproject/pymatgen#3571 (comment). thanks!

@janosh janosh added fix Bug fix PR version Package version-related issues labels Jan 26, 2024
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3b4c511) 76.25% compared to head (f4a9e57) 76.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #690   +/-   ##
=======================================
  Coverage   76.25%   76.25%           
=======================================
  Files          87       87           
  Lines        7151     7151           
  Branches     1057     1057           
=======================================
  Hits         5453     5453           
  Misses       1374     1374           
  Partials      324      324           
Files Coverage Δ
src/atomate2/vasp/sets/base.py 74.05% <77.77%> (ø)

@janosh janosh merged commit c3f126b into main Jan 26, 2024
7 checks passed
@janosh janosh deleted the prep-next-pmg-release branch January 26, 2024 07:24
@mkhorton
Copy link
Member

Apologies @utf, we're in a situation where the latest atomate2 is incompatible with the latest pymatgen. Would it be possible to mint an atomate2 release?

A secondary question, @utf are you the only person able to initiate an atomate2 release at present?

@JaGeo
Copy link
Member

JaGeo commented Feb 14, 2024

@mkhorton we have been installing atomate2 with [strict] for quite a while now as there were many issues because of the pydantic upgrade and incompatibilties with other MP codes. I think quite a few users have been doing this since then. Thus, the effect of this incompability should not be too big.

@janosh
Copy link
Member Author

janosh commented Feb 14, 2024

@JaGeo i went the other extreme for the same reasons and have been installing atomate2 from main these last couple of months 😄
which incidentally is why i didn't notice this fix hasn't been released yet. happy to help with that

@utf
Copy link
Member

utf commented Feb 14, 2024

@mkhorton thanks for raising this - unfortunately, the latest pymatgen had some bugs which meant it was not compatible with atomate2. Once a fixed version is released I can push a new atomate2 version.

Currently, I'm the only one pushing releases but technically @janosh is able to do it also (as can anyone with push access to main). If pushing atomate2 versions is something @janosh would be interested in, then happy to chat about it over email.

@utf
Copy link
Member

utf commented Feb 14, 2024

Also adding this for tracking: #719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PR version Package version-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants