Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all ruff PT011 (not checking error message when testing exceptions) #698

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Jan 30, 2024

a47d7a5 bump ruff pre-commit to v0.1.15
b5770cf ruff auto fixes
5beab45 fix all ruff PT011 and unignore that rule

@janosh janosh added the qa label Jan 30, 2024
@janosh janosh enabled auto-merge (squash) January 30, 2024 09:27
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4e50400) 76.32% compared to head (5beab45) 76.32%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #698   +/-   ##
=======================================
  Coverage   76.32%   76.32%           
=======================================
  Files          87       87           
  Lines        7164     7164           
  Branches     1061     1057    -4     
=======================================
  Hits         5468     5468           
- Misses       1372     1373    +1     
+ Partials      324      323    -1     
Files Coverage Δ
src/atomate2/common/schemas/defects.py 88.42% <100.00%> (+0.12%) ⬆️
src/atomate2/forcefields/utils.py 84.00% <100.00%> (+0.21%) ⬆️
src/atomate2/vasp/flows/mp.py 90.00% <100.00%> (+1.66%) ⬆️
src/atomate2/vasp/sets/base.py 74.55% <100.00%> (ø)
src/atomate2/utils/file_client.py 43.52% <0.00%> (ø)
src/atomate2/lobster/schemas.py 91.33% <81.81%> (-0.26%) ⬇️
src/atomate2/cp2k/sets/base.py 64.15% <62.50%> (ø)

@janosh janosh merged commit 23b3c4b into main Jan 30, 2024
7 checks passed
@janosh janosh deleted the bump-ruff branch January 30, 2024 09:41
@utf utf added the house-keeping Formatting and code quality tweaks label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
house-keeping Formatting and code quality tweaks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants