Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite for pymatgen vasprun fix #75

Merged
merged 1 commit into from
Feb 7, 2022
Merged

Fix test suite for pymatgen vasprun fix #75

merged 1 commit into from
Feb 7, 2022

Conversation

Andrew-S-Rosen
Copy link
Member

Updates test suite with correct energies so that pymatgen can be updated. Fixes (and can close) the error with #72.

@codecov-commenter
Copy link

Codecov Report

Merging #75 (5b7cdaa) into main (8d75d85) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   70.70%   70.70%           
=======================================
  Files          46       46           
  Lines        3973     3973           
  Branches      622      622           
=======================================
  Hits         2809     2809           
  Misses       1004     1004           
  Partials      160      160           

@utf
Copy link
Member

utf commented Feb 7, 2022

Fantastic. Thank you very much.

@utf utf merged commit 0a15fb9 into materialsproject:main Feb 7, 2022
@Andrew-S-Rosen Andrew-S-Rosen deleted the rosen-pmgtests branch February 7, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants