Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Documentation update #850

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AntObi
Copy link

@AntObi AntObi commented May 14, 2024

Summary

In the API reference of the current documentation for atomate2, not all of the subpackages and modules are displayed, which means that a new user to atomate2 will not be able to see all the new workflows added (e.g. forcefields, CP2K etc).
image

  • Fix 1: Add new subpackages to index.rst to update the documentation

TODO (if any)

image

  • Updating index.rst adds the subpackages to the API reference, but not all subpackages have been automatically documented correctly (see image above). I need to investigate the cause of this.
  • Need to document that when developers create a new subpackage, they should also add it to the index.rst file and also check that the documentation renders properly locally.

Checklist

Work-in-progress pull requests are encouraged, but please put [WIP] in the pull request
title.

Before a pull request can be merged, the following items must be checked:

  • Code is in the standard Python style.
    The easiest way to handle this is to run the following in the correct sequence on
    your local machine. Start with running ruff and ruff format on your new code. This will
    automatically reformat your code to PEP8 conventions and fix many linting issues.
  • Doc strings have been added in the Numpy docstring format.
    Run ruff on your code.
  • Type annotations are highly encouraged. Run mypy to
    type check your code.
  • Tests have been added for any new functionality or bug fixes.
  • All linting and tests pass.

@utf
Copy link
Member

utf commented May 14, 2024

Thanks very much @AntObi for the detailed PR. I'm happy to merge once the CI passes. I think the main issue is the punctuation that was removed.

To make things easier, you can install the pre-commit which will catch most things before committing.

pip install pre-commit
pre-commit install

@utf utf enabled auto-merge (squash) May 14, 2024 09:21
auto-merge was automatically disabled May 14, 2024 09:26

Head branch was pushed to by a user without write access

@AntObi
Copy link
Author

AntObi commented May 14, 2024

@utf Thanks for the fast response! You can hold off on merging this PR until I fix the issue with the forcefields subpackage not showing all of the available modules!

@JaGeo
Copy link
Member

JaGeo commented May 15, 2024

Great work, @AntObi ! Wondering if we should also update the readme?

@AntObi
Copy link
Author

AntObi commented May 17, 2024

Hi @utf @JaGeo , I think this PR will take longer than I expected 😅 .

TODO (if any)

image

  • Updating index.rst adds the subpackages to the API reference, but not all subpackages have been automatically documented correctly (see image above). I need to investigate the cause of this.
  • Need to document that when developers create a new subpackage, they should also add it to the index.rst file and also check that the documentation renders properly locally.

As I mentioned in the TODO for this PR, some of the subpackages/modules don't have their classes and functions appear in the docs. So far, I haven't been identify the cause of this (likely something I have to dig into Sphinx to find out).

@JaGeo What did you have in mind for updates to the README?

@utf
Copy link
Member

utf commented May 17, 2024

Hi @AntObi. All you should need to do is add the top level links. Sphinx-autodoc should do the rest. Can you try removing the build folder and rebuilding from scratch. Does that help at all?

@JaGeo
Copy link
Member

JaGeo commented May 18, 2024

@JaGeo What did you have in mind for updates to the README?

Similar to the publication draft, we could list all available calculators and highlight the most important workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants