Rewrite handler tests #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #299 +/- ##
==========================================
- Coverage 65.92% 64.86% -1.07%
==========================================
Files 51 51
Lines 5641 5465 -176
==========================================
- Hits 3719 3545 -174
+ Misses 1922 1920 -2
☔ View full report in Codecov by Sentry. |
rename single-letter vars
…rTest DriftErrorHandlerTest
…andlerTest PositiveEnergyHandlerTest
…est IncorrectSmearingHandlerFermiTest KspacingMetalHandlerTest LargeSigmaHandlerTest
|
Ran out of time. Only ones still missing are |
|
@janosh: Thank you for doing this valuable cleanup. I had thought about splitting these up into a greater number of individual tests and using pytests's |
janosh
force-pushed
the
refactor-handler-tests
branch
from
40f345e
to
08cdcb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in
custodian/vasp/tests/test_handlers.pyare laden with order-dependent side effects. Running all tests in that file does not leave thetest_files/unchanged. Large numbers of files are modified and added while tests run and again deleted at the end... but only if all tests pass. Failing tests leave behind dirty files in the repo that then cause subsequent test runs to fail that were previously passing.The right way to run IO-heavy tests like in Custodian is to move everything into temporary dirs that are auto-cleaned by the OS and can't affect anything inside the repo.