fixed typos

materialsproject · Mar 24, 2021 · 76ae6a9 · 76ae6a9
1 parent b60548a
commit 76ae6a9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/emmet-core/emmet/core/electrode.py b/emmet-core/emmet/core/electrode.py
@@ -65,11 +65,11 @@ class InsertionVoltagePairDoc(VoltagePairDoc):
     Features specific to insertion electrode
     """
 
-    formula_charge: float = Field(
+    formula_charge: str = Field(
         None, description="The chemical formula of the charged material."
     )
 
-    formula_discharge: float = Field(
+    formula_discharge: str = Field(
         None, description="The chemical formula of the discharged material."
     )
 
@@ -186,7 +186,7 @@ def from_entries(
         elements = sorted(
             host_structure.composition.elements + working_ion_entry.composition.elements
         )
-        chemsys = "-".join(elements)
+        chemsys = "-".join(sorted(map(str, elements)))
         return cls(
             battery_id=battery_id,
             host_structure=host_structure.as_dict(),