Skip to content

Commit

Permalink
remove deprecation from core since its in builders
Browse files Browse the repository at this point in the history
  • Loading branch information
shyamd committed May 27, 2021
1 parent 0210fc2 commit 8585077
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 13 deletions.
4 changes: 0 additions & 4 deletions emmet-core/emmet/core/settings.py
Expand Up @@ -79,10 +79,6 @@ class EmmetSettings(BaseSettings):
description="Maximum upward gradient in the last SCF for any VASP calculation",
)

VASP_DEPRECATED_TAGS: List[str] = Field(
[], description="List of tags to manually deprecate in task validation"
)

VASP_USE_STATICS: bool = Field(
True,
description="Use static calculations for structure and energy along with structure optimizations",
Expand Down
9 changes: 0 additions & 9 deletions emmet-core/emmet/core/vasp/validation.py
Expand Up @@ -13,7 +13,6 @@

class DeprecationMessage(DocEnum):
MANUAL = "M", "manual deprecation"
DEPRECATED_TAGS = "M001", "Deprecated tag"
KPTS = "C001", "Too few KPoints"
KSPACING = "C002", "KSpacing not high enough"
ENCUT = "C002", "ENCUT too low"
Expand Down Expand Up @@ -57,7 +56,6 @@ def from_task_doc(
input_sets: Dict[str, PyObject] = SETTINGS.VASP_DEFAULT_INPUT_SETS,
LDAU_fields: List[str] = SETTINGS.VASP_CHECKED_LDAU_FIELDS,
max_allowed_scf_gradient: float = SETTINGS.VASP_MAX_SCF_GRADIENT,
deprecated_tags: List[str] = SETTINGS.VASP_DEPRECATED_TAGS,
) -> "ValidationDoc":
"""
Determines if a calculation is valid based on expected input parameters from a pymatgen inputset
Expand Down Expand Up @@ -168,13 +166,6 @@ def from_task_doc(
if max_gradient > max_allowed_scf_gradient:
reasons.append(DeprecationMessage.MAX_SCF)

# Check for Manual deprecations
if deprecated_tags is not None:
bad_tags = list(set(task_doc.tags).intersection(deprecated_tags))
if len(bad_tags) > 0:
reasons.append(DeprecationMessage.DEPRECATED_TAGS)
data["bad_tags"] = bad_tags

doc = ValidationDoc(
task_id=task_doc.task_id,
calc_type=calc_type,
Expand Down

0 comments on commit 8585077

Please sign in to comment.