-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsisten version - Github Tags vs. _version.py #564
Comments
Yes, unfortunately this will always be the case as that version is updated after release using automated actions. We only use the version files for easy internal version detection in our code deployment pipelines. That being said, the code in from emmet.core import __version__ will always show the correctly installed version. |
But it affects |
Can you provide me more details about what issue you are running into? |
I provided a pull request to demonstrate how currently the installation from source fails: |
Perfect, thank you. I will take a look ASAP. |
One more change on my end. Once things look good I will close this issue. |
Reverted for now to fix deployment issues. Re-opening this until a new solution is found. |
The issue I have with the latest version is that the version is generated based on the git tag:
rather than
|
What is that messing up for you specifically? |
Hm, okay I will take a look. |
It seems this issue was fixed with the release of |
The
_version.py
files are always one version behind, for example:https://github.com/materialsproject/emmet/blob/v0.38.0/emmet-core/_version.py
The text was updated successfully, but these errors were encountered: