Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsisten version - Github Tags vs. _version.py #564

Closed
jan-janssen opened this issue Oct 21, 2022 · 12 comments · Fixed by #568
Closed

Inconsisten version - Github Tags vs. _version.py #564

jan-janssen opened this issue Oct 21, 2022 · 12 comments · Fixed by #568

Comments

@jan-janssen
Copy link
Contributor

The _version.py files are always one version behind, for example:
https://github.com/materialsproject/emmet/blob/v0.38.0/emmet-core/_version.py

@munrojm
Copy link
Member

munrojm commented Oct 21, 2022

Yes, unfortunately this will always be the case as that version is updated after release using automated actions. We only use the version files for easy internal version detection in our code deployment pipelines.

That being said, the code in main will always be up to date with the latest release. Additionally, this should not affect users as code like

from emmet.core import __version__

will always show the correctly installed version.

@jan-janssen
Copy link
Contributor Author

But it affects pip check.

@munrojm
Copy link
Member

munrojm commented Oct 21, 2022

Can you provide me more details about what issue you are running into?

@jan-janssen
Copy link
Contributor Author

I provided a pull request to demonstrate how currently the installation from source fails:
#565

@munrojm
Copy link
Member

munrojm commented Oct 21, 2022

Perfect, thank you. I will take a look ASAP.

@munrojm
Copy link
Member

munrojm commented Oct 22, 2022

One more change on my end. Once things look good I will close this issue.

@munrojm munrojm closed this as completed Oct 22, 2022
@munrojm
Copy link
Member

munrojm commented Oct 22, 2022

Reverted for now to fix deployment issues. Re-opening this until a new solution is found.

@jan-janssen
Copy link
Contributor Author

The issue I have with the latest version is that the version is generated based on the git tag:

emmet-core 0.1.dev76+g7b6631a.d20221023.

rather than

emmet-core 0.36.4

@munrojm
Copy link
Member

munrojm commented Oct 24, 2022

What is that messing up for you specifically?

@jan-janssen
Copy link
Contributor Author

@munrojm
Copy link
Member

munrojm commented Oct 24, 2022

Hm, okay I will take a look.

@munrojm munrojm reopened this Oct 24, 2022
@jan-janssen
Copy link
Contributor Author

It seems this issue was fixed with the release of 0.38.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants