Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pip install with --no-binary #568

Merged
merged 1 commit into from Oct 22, 2022
Merged

Fix pip install with --no-binary #568

merged 1 commit into from Oct 22, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 22, 2022

Force get_version() from setuptools_scm to search parent directories for git metadata.

Fixes #564

@munrojm munrojm added the release:patch Patch updates label Oct 22, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 92.33% // Head: 90.83% // Decreases project coverage by -1.49% ⚠️

Coverage data is based on head (15df2d8) compared to base (31a2262).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
- Coverage   92.33%   90.83%   -1.50%     
==========================================
  Files          60       35      -25     
  Lines        3364     1244    -2120     
==========================================
- Hits         3106     1130    -1976     
+ Misses        258      114     -144     
Impacted Files Coverage Δ
...ders/emmet/builders/materials/basic_descriptors.py
...met-builders/emmet/builders/vasp/task_validator.py
emmet-builders/emmet/builders/vasp/materials.py
...lders/emmet/builders/materials/oxidation_states.py
emmet-builders/emmet/builders/materials/chemenv.py
emmet-builders/emmet/builders/molecules/redox.py
...met-builders/emmet/builders/materials/magnetism.py
emmet-builders/emmet/builders/qchem/molecules.py
...mmet-builders/emmet/builders/molecules/orbitals.py
emmet-builders/emmet/builders/molecules/thermo.py
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 3e64b4f into main Oct 22, 2022
@munrojm munrojm deleted the bugfix/no_binary_install branch October 22, 2022 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsisten version - Github Tags vs. _version.py
2 participants