Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate static run-types for IDEs #141

Merged
merged 7 commits into from Nov 18, 2020
Merged

Generate static run-types for IDEs #141

merged 7 commits into from Nov 18, 2020

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Nov 18, 2020

This PR switches the dynamic run type enum for static enums so IDE autocompletion and mypy checks work.

@codecov-io
Copy link

Codecov Report

Merging #141 (1b673de) into master (2e1fdbb) will increase coverage by 6.18%.
The diff coverage is 99.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   87.14%   93.33%   +6.18%     
==========================================
  Files          18       20       +2     
  Lines         677     1350     +673     
==========================================
+ Hits          590     1260     +670     
- Misses         87       90       +3     
Impacted Files Coverage Δ
emmet-core/emmet/core/material.py 97.36% <ø> (-0.14%) ⬇️
emmet-core/emmet/core/structure.py 100.00% <ø> (ø)
emmet-core/emmet/core/vasp/validation.py 57.40% <ø> (-0.78%) ⬇️
emmet-core/emmet/core/vasp/calc_types/__init__.py 71.42% <71.42%> (ø)
emmet-core/emmet/core/symmetry.py 93.54% <100.00%> (ø)
emmet-core/emmet/core/utils.py 78.33% <100.00%> (+0.15%) ⬆️
emmet-core/emmet/core/vasp/calc_types/enums.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/vasp/calc_types/utils.py 88.70% <100.00%> (ø)
emmet-core/emmet/core/vasp/task.py 98.50% <100.00%> (ø)
emmet-core/emmet/stubs/utils.py 53.52% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65e54e3...1b673de. Read the comment docs.

@shyamd shyamd merged commit 419d3a0 into master Nov 18, 2020
@shyamd shyamd deleted the static-gen-run_types branch March 7, 2021 23:43
utf referenced this pull request in utf/emmet May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants