Electrode Doc

[jmmshn]

Bare branch for defining electrode document used in the InsertionElectrode builder.

[codecov-io]

Codecov Report

Merging #149 (3841e6a) into master (d88fa51) will decrease coverage by 0.36%.
The diff coverage is 98.64%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   93.84%   93.48%   -0.37%     
==========================================
  Files          24       25       +1     
  Lines        1414     1488      +74     
==========================================
+ Hits         1327     1391      +64     
- Misses         87       97      +10     

Impacted Files	Coverage Δ
emmet-core/emmet/core/electrode.py	98.64% <98.64%> (ø)
emmet-core/emmet/core/thermo.py	75.00% <0.00%> (-18.75%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c7ae13...3841e6a. Read the comment docs.

[jmmshn]

@shyamd this is ready to merge

[shyamd]

Some small changes. Do you need these large data dump file for testing? This shouldn't be a place where you store data as that makes the repo unwieldy.

[jmmshn]

This shouldn't be a place where you store data as that makes the repo unwieldy.

I think following the same cases/pattern as pymatgen here makes life easier for future development.
I think it's also possible to grab the test case directly from the pymatgen installed on the system but that seemed hacky.