Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile changes on updates branch #199

Merged
merged 27 commits into from May 28, 2021
Merged

Reconcile changes on updates branch #199

merged 27 commits into from May 28, 2021

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented May 28, 2021

This PR should reconcile major changes on the updates branch to ensure validation, materials, and thermo builds the same way.

@codecov-commenter
Copy link

Codecov Report

Merging #199 (cb293cd) into main (9082fc4) will decrease coverage by 0.41%.
The diff coverage is 94.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #199      +/-   ##
==========================================
- Coverage   95.33%   94.91%   -0.42%     
==========================================
  Files          26       26              
  Lines        1778     1848      +70     
==========================================
+ Hits         1695     1754      +59     
- Misses         83       94      +11     
Impacted Files Coverage Δ
emmet-core/emmet/core/oxidation_states.py 71.42% <0.00%> (-18.82%) ⬇️
emmet-core/emmet/core/vasp/validation.py 86.58% <77.77%> (-2.15%) ⬇️
emmet-core/emmet/core/settings.py 89.36% <100.00%> (+0.23%) ⬆️
emmet-core/emmet/core/thermo.py 90.00% <100.00%> (ø)
emmet-core/emmet/core/vasp/calc_types/enums.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/vasp/material.py 98.18% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9082fc4...cb293cd. Read the comment docs.

@shyamd shyamd merged commit 1d187e6 into main May 28, 2021
@shyamd shyamd deleted the reconcile branch May 28, 2021 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants