Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix oxidation document #201

Merged
merged 6 commits into from Jun 7, 2021
Merged

Fix oxidation document #201

merged 6 commits into from Jun 7, 2021

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jun 7, 2021

Fixes some minor bugs with the oxidation state document and adds proper descriptions
Also fixes MPID to properly validate integers

@shyamd shyamd added the release:patch Patch updates label Jun 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #201 (21df762) into main (b738071) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   94.84%   95.01%   +0.17%     
==========================================
  Files          26       26              
  Lines        1823     1825       +2     
==========================================
+ Hits         1729     1734       +5     
+ Misses         94       91       -3     
Impacted Files Coverage Δ
emmet-core/emmet/core/mpid.py 91.48% <100.00%> (+4.82%) ⬆️
emmet-core/emmet/core/oxidation_states.py 73.17% <100.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b738071...21df762. Read the comment docs.

@shyamd shyamd merged commit 3634420 into main Jun 7, 2021
@shyamd shyamd deleted the fix-oxidation branch June 7, 2021 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants