Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert materials finding to old pipeline behavior #203

Merged
merged 2 commits into from
Jun 14, 2021
Merged

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jun 14, 2021

Temporarily "fixes" two issues:

  • material_id was being pinned to any task vs before we pinned to lowest structure opt
  • statics should be hard preferred when available rather than just on energy

@shyamd shyamd added the release:patch Patch updates label Jun 14, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #203 (39cb46c) into main (6d6425f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #203   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files          26       26           
  Lines        1825     1826    +1     
=======================================
+ Hits         1734     1735    +1     
  Misses         91       91           
Impacted Files Coverage Δ
emmet-core/emmet/core/vasp/material.py 98.21% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d6425f...39cb46c. Read the comment docs.

@shyamd shyamd merged commit 16cc016 into main Jun 14, 2021
@shyamd shyamd deleted the revert_mat_finding branch June 14, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants