-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Validation #215
Fix Validation #215
Conversation
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 85.98% 85.96% -0.02%
==========================================
Files 37 37
Lines 1798 1810 +12
==========================================
+ Hits 1546 1556 +10
- Misses 252 254 +2
Continue to review full report at Codecov.
|
Is this to ensure GGA calcs don't get deprecated? |
The opposite. This is to ensure if the calc should be a GGA, but was run with +U, it gets deprecated. I was only checking one way previously: if input_set wants +U, check if appropriate +U. |
# Conflicts: # emmet-builders/emmet/builders/materials/oxidation_states.py
Sigh it seems there are still lots of bugs in validation. This PR is attempting to fix them all