Update Redox Elements #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #482 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 115 115
Lines 23900 23900
=======================================
Hits 23334 23334
Misses 566 566 Continue to review full report at Codecov.
|
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the June 13, 2022 meeting and discussion with Kristin and other Persson Group members, we would like to make the InsertionElectrodes builder consistent with the screening process used for identifying intercalation electrodes in research. Therefore the list of redox active elements was updated to remove Hf (only affects two battery entries on MP) and add Ag.