Permit electrodes with non-TM redox active species #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e not transition metals
Codecov Report
@@ Coverage Diff @@
## main #484 +/- ##
==========================================
- Coverage 97.63% 97.62% -0.01%
==========================================
Files 115 115
Lines 23900 23902 +2
==========================================
+ Hits 23334 23335 +1
- Misses 566 567 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are valid electrodes that contain redox active species which are not transition metals (e.g. Sn, Sb, Bi, C). The InsertionElectrodeDocument had a check which assumes the presence of transition metals in the host material which created an error for any electrodes that contained non-transition-metal redox active species.
An if statement has been added to check for the presence of a transition metal to avoid this error and a warning has been added ("Transition metal not found") instead. Now the InsertionElectrodesBuilder can successfully process electrodes that only contain Sn, Sb, Bi, or C as the redox active specie.