Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spin isnan detection for density of states processing #503

Merged
merged 1 commit into from Aug 15, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Aug 15, 2022

Adds a None check to spin polarization in dos processing for electronic structure builder.

@munrojm munrojm added the release:patch Patch updates label Aug 15, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #503 (4fb87d9) into main (32a5402) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   97.56%   97.53%   -0.03%     
==========================================
  Files         116       91      -25     
  Lines       24120    21998    -2122     
==========================================
- Hits        23532    21456    -2076     
+ Misses        588      542      -46     
Impacted Files Coverage Δ
emmet-core/emmet/core/electronic_structure.py 94.54% <100.00%> (-0.61%) ⬇️
emmet-core/emmet/core/utils.py 57.69% <0.00%> (-32.70%) ⬇️
emmet-core/emmet/core/oxidation_states.py 73.33% <0.00%> (-17.78%) ⬇️
emmet-core/emmet/core/qchem/molecule.py 80.18% <0.00%> (-16.99%) ⬇️
emmet-core/emmet/core/summary.py 80.00% <0.00%> (-10.38%) ⬇️
emmet-core/emmet/core/settings.py 88.52% <0.00%> (-9.84%) ⬇️
emmet-core/emmet/core/vasp/calc_types/utils.py 82.45% <0.00%> (-7.02%) ⬇️
emmet-core/emmet/core/molecules/atomic.py 93.15% <0.00%> (-2.74%) ⬇️
emmet-core/emmet/core/mpid.py 94.44% <0.00%> (-1.86%) ⬇️
emmet-core/emmet/core/molecules/bonds.py 80.72% <0.00%> (-1.81%) ⬇️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@munrojm munrojm merged commit a3d3eeb into main Aug 15, 2022
@munrojm munrojm deleted the bugfix/electronic_structure_spin branch August 15, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants