Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chunk size to Structure Group Builder #528

Merged
merged 3 commits into from Sep 7, 2022

Conversation

acrutt
Copy link
Contributor

@acrutt acrutt commented Sep 7, 2022

Add chunk size to Structure Group Builder

@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #528 (c3e631d) into main (5a988de) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #528      +/-   ##
==========================================
- Coverage   97.52%   97.50%   -0.02%     
==========================================
  Files         116       91      -25     
  Lines       24142    22020    -2122     
==========================================
- Hits        23544    21471    -2073     
+ Misses        598      549      -49     
Impacted Files Coverage Δ
emmet-core/emmet/core/utils.py 57.69% <0.00%> (-32.70%) ⬇️
emmet-core/emmet/core/oxidation_states.py 73.33% <0.00%> (-17.78%) ⬇️
emmet-core/emmet/core/qchem/molecule.py 80.18% <0.00%> (-16.99%) ⬇️
emmet-core/emmet/core/summary.py 80.00% <0.00%> (-10.38%) ⬇️
emmet-core/emmet/core/settings.py 88.52% <0.00%> (-9.84%) ⬇️
emmet-core/emmet/core/vasp/calc_types/utils.py 82.45% <0.00%> (-7.02%) ⬇️
emmet-core/emmet/core/molecules/atomic.py 93.15% <0.00%> (-2.74%) ⬇️
emmet-core/emmet/core/mpid.py 94.44% <0.00%> (-1.86%) ⬇️
emmet-core/emmet/core/molecules/bonds.py 80.72% <0.00%> (-1.81%) ⬇️
emmet-core/emmet/core/elasticity.py 84.09% <0.00%> (-1.37%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@acrutt acrutt changed the title [WIP] Add chunk size to Structure Group Builder Add chunk size to Structure Group Builder Sep 7, 2022
@acrutt
Copy link
Contributor Author

acrutt commented Sep 7, 2022

@munrojm this passed the tests so I think it's ready to merge. But please let me know if you'd like me to make any edits!

@munrojm
Copy link
Member

munrojm commented Sep 7, 2022

Thanks @acrutt!

@munrojm munrojm added the release:patch Patch updates label Sep 7, 2022
@munrojm munrojm merged commit d62de3a into materialsproject:main Sep 7, 2022
@acrutt acrutt deleted the sg_chunk_size branch September 8, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants