Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debugging print statement #529

Merged
merged 2 commits into from Sep 13, 2022
Merged

Conversation

acrutt
Copy link
Contributor

@acrutt acrutt commented Sep 8, 2022

Remove debugging print statement from Migration Graph builder

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #529 (e615f2e) into main (282b625) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   97.51%   97.51%   -0.01%     
==========================================
  Files         116      116              
  Lines       24145    24144       -1     
==========================================
- Hits        23545    23544       -1     
  Misses        600      600              
Impacted Files Coverage Δ
...uilders/emmet/builders/mobility/migration_graph.py 83.33% <ø> (-0.39%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@acrutt
Copy link
Contributor Author

acrutt commented Sep 9, 2022

@munrojm the segmentation fault error is popping up again? But it looks like the testing environment is using an older version of spg.

Collecting spglib>=1.9.9.44
Downloading spglib-2.0.1-cp39-cp39-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (514 kB)

@munrojm
Copy link
Member

munrojm commented Sep 9, 2022

I was under the impression it was an issue with spglib >= 2.0 which I have fixed in emmet-core

@acrutt acrutt changed the title [WIP] Remove debugging print statement Remove debugging print statement Sep 13, 2022
@acrutt
Copy link
Contributor Author

acrutt commented Sep 13, 2022

@munrojm tests are passing now so I think we should be good!

@munrojm
Copy link
Member

munrojm commented Sep 13, 2022

Thanks @acrutt!

@munrojm munrojm added the release:patch Patch updates label Sep 13, 2022
@munrojm munrojm merged commit c0e32db into materialsproject:main Sep 13, 2022
@acrutt acrutt deleted the clean_up branch September 13, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants