Fix use of PatchedPhaseDiagram in ThermoBuilder
#566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 97.33% // Head: 92.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 97.33% 92.33% -5.01%
==========================================
Files 131 60 -71
Lines 24435 3364 -21071
==========================================
- Hits 23785 3106 -20679
+ Misses 650 258 -392 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jan-janssen
reviewed
Oct 22, 2022
| @@ -8,9 +8,9 @@ | |||
| setup( | |||
| name="emmet-api", | |||
| use_scm_version={ | |||
| "root": ".", | |||
| "root": "..", | |||
There was a problem hiding this comment.
This basically reverts #565
There was a problem hiding this comment.
Yes, I had to revert as the git information wasn't properly being accessed by setuptools when root is set to .
I will try and find another solution, but in the mean time this change needed to happen so our deployment pipelines don't break.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures base phase diagram always gets built when using
PatchedPhaseDiagraminThermoBuilder.