Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Origin data audit #696

Merged
merged 10 commits into from
Apr 10, 2023
Merged

Origin data audit #696

merged 10 commits into from
Apr 10, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 10, 2023

This PR ensures all relevant builders are properly storing origin data, and that the origins field in summary is properly populated.

@munrojm munrojm added the release:patch Patch updates label Apr 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Patch coverage: 87.09% and no project coverage change.

Comparison is base (a452bb0) 90.65% compared to head (9ec78c6) 90.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #696   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files         148      148           
  Lines       11425    11448   +23     
=======================================
+ Hits        10357    10378   +21     
- Misses       1068     1070    +2     
Impacted Files Coverage Δ
emmet-core/emmet/core/electronic_structure.py 93.88% <83.33%> (-1.27%) ⬇️
...s/emmet/builders/materials/electronic_structure.py 87.17% <86.84%> (+0.27%) ⬆️
...et-builders/emmet/builders/materials/elasticity.py 81.81% <100.00%> (+0.19%) ⬆️
emmet-core/emmet/core/summary.py 91.17% <100.00%> (+0.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 2682d3d into main Apr 10, 2023
15 checks passed
@munrojm munrojm deleted the enhancment/origin_audit branch April 10, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants