-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the Materials Project [WIP] #698
Conversation
…ut how to effectively query dictionaries
…I side (still need to update core and builders
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #698 +/- ##
==========================================
- Coverage 90.65% 87.87% -2.78%
==========================================
Files 148 120 -28
Lines 11450 7210 -4240
==========================================
- Hits 10380 6336 -4044
+ Misses 1070 874 -196
... and 41 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Alright, I've gone through and changed some names in emmet-core and emmet-builders. I was too lazy to create a new directory structure to group all of the materials stuff (though it should be done at some point). |
@espottesmith thanks again for all this restructuring. Everything looks good to me. Are you happy to have it merged now? |
Yep, happy to have it merged if you are. |
Title is a little lofty, but that's basically what we're doing here. This PR (mainly) moves things around and renames them to follow a new structure for the MP API:
This is listed as WIP for two reasons:
Only API has been touched, and all API tests pass locally.