Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure open data requests are unsigned #804

Merged
merged 2 commits into from
Aug 11, 2023
Merged

Ensure open data requests are unsigned #804

merged 2 commits into from
Aug 11, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Aug 11, 2023

Ensure all S3 requests from the electronic structure builder are unsigned

@munrojm munrojm added the release:patch Patch updates label Aug 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.96% ⚠️

Comparison is base (7a3548b) 90.98% compared to head (88ef8e2) 88.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #804      +/-   ##
==========================================
- Coverage   90.98%   88.02%   -2.96%     
==========================================
  Files         136      107      -29     
  Lines       11720     7218    -4502     
==========================================
- Hits        10663     6354    -4309     
+ Misses       1057      864     -193     

see 46 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 6b2c77f into main Aug 11, 2023
13 checks passed
@munrojm munrojm deleted the bugfix/unsigned_s3_es branch August 11, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants