Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a missing composition builder #816

Merged
merged 3 commits into from
Aug 29, 2023
Merged

add a missing composition builder #816

merged 3 commits into from
Aug 29, 2023

Conversation

yang-ruoxi
Copy link
Member

@yang-ruoxi yang-ruoxi commented Aug 24, 2023

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
    • Add a Matscholar builder
    • It pulls from the phase diagram store and the MPContribs store to form a new Missing Composition collection
    • The Missing Composition collection has a very simple document model: e.g.
      "chemical_system": "O-Si", "missing_compositions": [ {"SiO100": {"link": xxx, "DOI": yyy} , {"Si100O": {"link": xxx, "DOI": yyy} ]
  • I have tested run the builder locally, serially and generated a store that has correct data
  • Test has been added.
    Note :
  • According to @computron the text mining project has discontinued, so I presume the MPContribs data will not be updated. However, the missing compositions store will be updated because we will likely run those compositions in the future. To this regard, I would imagine this builder needs to be run in sync with the Phase Diagram builder.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.50% 🎉

Comparison is base (900e3f2) 90.95% compared to head (91629e9) 91.46%.
Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
+ Coverage   90.95%   91.46%   +0.50%     
==========================================
  Files         137      136       -1     
  Lines       11725    12609     +884     
==========================================
+ Hits        10665    11533     +868     
- Misses       1060     1076      +16     

see 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 464c38e into main Aug 29, 2023
13 checks passed
@munrojm munrojm deleted the matscholar branch August 30, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants