Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small pydantic related bug fixes and linting #836

Merged
merged 8 commits into from
Sep 27, 2023
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Sep 26, 2023

No description provided.

@munrojm munrojm added the release:patch Patch updates label Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (dac2e71) 78.99% compared to head (8d4b4d1) 91.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #836       +/-   ##
===========================================
+ Coverage   78.99%   91.34%   +12.35%     
===========================================
  Files          75      138       +63     
  Lines        4208    12745     +8537     
===========================================
+ Hits         3324    11642     +8318     
- Misses        884     1103      +219     
Files Coverage Δ
emmet-core/emmet/core/elasticity.py 86.69% <100.00%> (ø)
emmet-core/emmet/core/electronic_structure.py 93.88% <100.00%> (+55.00%) ⬆️
emmet-core/emmet/core/qchem/molecule.py 93.71% <ø> (ø)
emmet-core/emmet/core/vasp/validation.py 70.37% <100.00%> (+43.20%) ⬆️
emmet-core/emmet/core/tasks.py 86.58% <83.33%> (ø)
emmet-core/emmet/core/structure_group.py 52.89% <0.00%> (ø)

... and 71 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit c2fad96 into main Sep 27, 2023
10 checks passed
@munrojm munrojm deleted the bugfix/pydantic_2_cleanup branch November 13, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants