Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PyObject pydantic type from model type hints #838

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Sep 27, 2023

This type is deprecated and causing warnings.

@munrojm munrojm added the release:patch Patch updates label Sep 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c2fad96) 91.34% compared to head (edc7fb1) 91.34%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
- Coverage   91.34%   91.34%   -0.01%     
==========================================
  Files         138      138              
  Lines       12745    12744       -1     
==========================================
- Hits        11642    11641       -1     
  Misses       1103     1103              
Files Coverage Δ
emmet-core/emmet/core/settings.py 98.33% <100.00%> (-0.03%) ⬇️
emmet-core/emmet/core/vasp/validation.py 70.37% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit dc71e0b into main Sep 27, 2023
10 checks passed
@munrojm munrojm deleted the bugfix/remove_pyobject_type branch November 13, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants