Fix TaskDoc.from_directory
when dir_name != "."
#873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bug with TaskDoc construction when
TaskDoc.from_directory
is called on a directory other than "." (dir_name
arg).In
emmet.core.tasks._find_vasp_files
, output files with the leading path are returned. When these files are fed toemmet.core.vasp.Calculation.from_vasp_files(...)
(for example),dir_name
will appear twice.Ex:
_find_vasp_files
returns <dir_name>/OUTCAR, whichCalculation.from_vasp_files
turns into <dir_name>/<dir_name>/OUTCAR