Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TaskDoc.from_directory when dir_name != "." #873

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

esoteric-ephemera
Copy link
Contributor

Minor bug with TaskDoc construction when TaskDoc.from_directory is called on a directory other than "." (dir_name arg).

In emmet.core.tasks._find_vasp_files, output files with the leading path are returned. When these files are fed to emmet.core.vasp.Calculation.from_vasp_files(...) (for example), dir_name will appear twice.

Ex: _find_vasp_files returns <dir_name>/OUTCAR, which Calculation.from_vasp_files turns into <dir_name>/<dir_name>/OUTCAR

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ebbe8d5) 91.36% compared to head (caead33) 91.36%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   91.36%   91.36%           
=======================================
  Files         138      138           
  Lines       12748    12749    +1     
=======================================
+ Hits        11647    11648    +1     
  Misses       1101     1101           
Files Coverage Δ
emmet-core/emmet/core/tasks.py 87.27% <83.33%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 123e8ea into materialsproject:main Nov 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants