Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix summary hint scheme for excluding elements #906

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Nov 28, 2023

Ensures summary hint scheme accommodates exclude_elements

@munrojm munrojm added the release:patch Patch updates label Nov 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3b5815e) 90.85% compared to head (130e0ca) 90.84%.

Files Patch % Lines
.../emmet/api/routes/materials/summary/hint_scheme.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #906      +/-   ##
==========================================
- Coverage   90.85%   90.84%   -0.01%     
==========================================
  Files         137      137              
  Lines       12820    12826       +6     
==========================================
+ Hits        11647    11652       +5     
- Misses       1173     1174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 66a49a1 into main Nov 28, 2023
9 of 10 checks passed
@munrojm munrojm deleted the bugfix/exclude_elements_hint_scheme branch November 28, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants