Correct typing of TaskDoc.transformations field #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #937 +/- ##
==========================================
+ Coverage 90.15% 90.21% +0.06%
==========================================
Files 138 138
Lines 13159 13159
==========================================
+ Hits 11864 11872 +8
+ Misses 1295 1287 -8 ☔ View full report in Codecov by Sentry. |
This was referenced Feb 15, 2024
|
Hi @munrojm, once this is merged is it possible to get a new emmet-core released? Were't hoping this will be the final fix needed to support the latest pydantic version in atomate2. |
|
Yup! Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objects stored in TaskDoc.transformations can be serialized at init (for example,
pymatgen.alchemy.materials.TransformedStructure), which leads to pydantic typing errors. This happens in atomate2 when output references are resolved, see discussion in atomate2 PR #623.This PR allows the typing of
TaskDoc.transformationsto beAny, and adds tests for the new behavior.This would close atomate2 issue #607.