Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SSHTunnel in job stores #477

Merged
merged 2 commits into from Dec 5, 2023
Merged

Conversation

mjwen
Copy link
Member

@mjwen mjwen commented Nov 7, 2023

Summary

Allow the use of SSHTunnel in job stores. This will make it possible to use a jobflow.yaml like the below

  docs_store:
    type: MongoStore
    ssh_tunnel:
      type: SSHTunnel
      ...
  additional_stores:
    data:
      type: S3Store
        ...
      index:
        ...
      s3_profile:
        ...
      ssh_tunnel:
        type: SSHTunnel
        ...

MongoStore already have ssh tunnel support. Support for S3Store is coming from this PR materialsproject/maggma#882

The SSHTunnel class is simply added to the all_stores variable. Technically, all_stores no longer only contains stores. So, we might want to change the variable name.

@mjwen
Copy link
Member Author

mjwen commented Nov 7, 2023

Test fails because SSHTunnel is relocated in this PR materialsproject/maggma#882

Once that is merged, we should be good.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #477 (e8fa70c) into main (43f8463) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #477   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files          20       20           
  Lines        1510     1512    +2     
  Branches      416      416           
=======================================
+ Hits         1508     1510    +2     
  Misses          2        2           
Files Coverage Δ
src/jobflow/core/store.py 100.00% <100.00%> (ø)

@utf
Copy link
Member

utf commented Dec 5, 2023

Thanks!

@utf utf merged commit 2e24ce1 into materialsproject:main Dec 5, 2023
8 checks passed
@utf utf added the enhancement New feature or request label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants