Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteria/properties order of MongoStore.query #37

Closed
mkhorton opened this issue Aug 24, 2018 · 3 comments
Closed

Criteria/properties order of MongoStore.query #37

mkhorton opened this issue Aug 24, 2018 · 3 comments

Comments

@mkhorton
Copy link
Member

I appreciate they're kwargs anyway, but is there a reason their order is reversed compared to pymongo? Think this might easily confuse people. (Also why query over find? for same reason)

@montoyjh
Copy link
Contributor

Yes, this is on the list of todos, see #31. I think generally these were designed to reflect QueryEngine syntax. I'd prefer to keep query because it's similar to the rest interface and it's a bit distinct from find in that one can specify a list of properties as opposed to a dictionary for projection.

@mkhorton
Copy link
Member Author

mkhorton commented Aug 24, 2018 via email

@dwinston
Copy link
Member

@montoyjh FYI one can specify a list of properties to a pymongo collection’s find, but in general I’d also like to have a different name for other abilities to mix in such as field aliasing (as MPRester.query does).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants