Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Engine equivalent #9

Closed
shyamd opened this issue Oct 31, 2017 · 3 comments
Closed

Query Engine equivalent #9

shyamd opened this issue Oct 31, 2017 · 3 comments
Assignees

Comments

@shyamd
Copy link
Contributor

shyamd commented Oct 31, 2017

There are a lot of key capabilities that need to be wrapped into some class such as query engine that implements find and return capabilities agnostic of find, distinct, etc.

  • This is important to wrap all the different way data can be accessed, e.g. direct mongo or gridFS
  • Implement the same flat properties that pymatgen-db QueryEngine implements?
  • implicit sandboxing
  • provide structure agnostic access for data.
  • eventual usage of aggregation pipelines across collections
@shyamd shyamd self-assigned this Oct 31, 2017
@shyamd
Copy link
Contributor Author

shyamd commented Nov 8, 2017

Began working on this by implementing an AliasingStore. I imagine all of this functionality can be layered by creating the appropriate advanced store. This does require that all buidlers use the accessors provided by store rather then trying to use the collections themselves.

@dwinston
Copy link
Member

@shyamd please update with current status given various new recent additions.

@shyamd
Copy link
Contributor Author

shyamd commented Apr 12, 2018

At this point we have:

  • Aliasing
  • Sandboxing

There are some materials specific access patterns, but I'm not sure those should be in the store. I think this is mostly done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants