Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert store close apart from S3 #818

Merged
merged 3 commits into from Jul 7, 2023
Merged

Revert store close apart from S3 #818

merged 3 commits into from Jul 7, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jul 7, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.29 🎉

Comparison is base (1ce76d3) 87.84% compared to head (6a6a608) 88.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #818      +/-   ##
==========================================
+ Coverage   87.84%   88.13%   +0.29%     
==========================================
  Files          44       44              
  Lines        3652     3624      -28     
==========================================
- Hits         3208     3194      -14     
+ Misses        444      430      -14     
Impacted Files Coverage Δ
src/maggma/api/resource/post_resource.py 89.83% <ø> (+2.33%) ⬆️
src/maggma/api/resource/read_resource.py 85.84% <ø> (+2.37%) ⬆️
src/maggma/api/resource/s3_url.py 59.18% <ø> (+3.62%) ⬆️
src/maggma/api/resource/submission.py 80.64% <ø> (+1.37%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit f40f515 into main Jul 7, 2023
11 checks passed
@munrojm munrojm deleted the bugfix/s3_store_coll branch July 7, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant