Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup: isort, updated classifiers, remove unused kwarg #833

Merged
merged 1 commit into from Jul 27, 2023
Merged

Some cleanup: isort, updated classifiers, remove unused kwarg #833

merged 1 commit into from Jul 27, 2023

Conversation

Andrew-S-Rosen
Copy link
Member

This PR accomplishes three and only three things:

  1. I applied isort . on the repo.
  2. I updated the Python classifiers in setup.py to include 3.7 through 3.11 instead of just 3.7.
  3. I removed an unused kwarg from maggma.stores.file_store.FileStore.connect().

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (12bba1c) 88.10% compared to head (8df0172) 88.09%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #833      +/-   ##
==========================================
- Coverage   88.10%   88.09%   -0.01%     
==========================================
  Files          44       44              
  Lines        3631     3629       -2     
==========================================
- Hits         3199     3197       -2     
  Misses        432      432              
Files Changed Coverage Δ
src/maggma/api/resource/__init__.py 100.00% <100.00%> (ø)
src/maggma/api/resource/aggregation.py 89.58% <100.00%> (ø)
src/maggma/api/resource/core.py 80.00% <100.00%> (ø)
src/maggma/api/resource/read_resource.py 85.71% <100.00%> (-0.14%) ⬇️
src/maggma/api/resource/s3_url.py 58.33% <100.00%> (-0.86%) ⬇️
src/maggma/api/utils.py 95.94% <100.00%> (ø)
src/maggma/cli/__init__.py 86.58% <100.00%> (ø)
src/maggma/cli/distributed.py 81.09% <100.00%> (ø)
src/maggma/cli/multiprocessing.py 94.73% <100.00%> (ø)
src/maggma/stores/aws.py 91.74% <100.00%> (ø)
... and 6 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 3722273 into materialsproject:main Jul 27, 2023
11 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the cleanup branch July 27, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants