Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Setting up MongoDB" guide to the docs and update README #849

Merged
merged 4 commits into from Aug 30, 2023
Merged

Add a "Setting up MongoDB" guide to the docs and update README #849

merged 4 commits into from Aug 30, 2023

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Aug 30, 2023

Closes #845 by adding a "Setting up MongoDB" guide to the docs. I also updated the README by removing the now deprecated lgtm badge and clarified that maggma is not just for MongoDB.

@Andrew-S-Rosen Andrew-S-Rosen changed the title Add a "Setting up MongoDB" guide to the docs Add a "Setting up MongoDB" guide to the docs and update README Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7353e57) 88.14% compared to head (436a47c) 88.14%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #849   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files          44       44           
  Lines        3593     3593           
=======================================
  Hits         3167     3167           
  Misses        426      426           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury
Copy link
Collaborator

This is great @arosen93, thanks!

@rkingsbury rkingsbury merged commit dba5558 into materialsproject:main Aug 30, 2023
11 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the docs branch August 30, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would the maggma docs be a good place to host MongoDB setup instructions?
2 participants