Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header processing with enabled validation #871

Merged
merged 1 commit into from Oct 13, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Oct 13, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (db7e614) 87.93% compared to head (da8371e) 87.78%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #871      +/-   ##
==========================================
- Coverage   87.93%   87.78%   -0.15%     
==========================================
  Files          44       44              
  Lines        3604     3610       +6     
==========================================
  Hits         3169     3169              
- Misses        435      441       +6     
Files Coverage Δ
src/maggma/api/resource/s3_url.py 56.00% <0.00%> (-2.34%) ⬇️
src/maggma/api/resource/read_resource.py 82.56% <0.00%> (-3.15%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit d32ed67 into main Oct 13, 2023
8 of 10 checks passed
@munrojm munrojm deleted the bugfix/fix_header_processing branch October 13, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant