Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hint in count for S3Store #888

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Remove hint in count for S3Store #888

merged 1 commit into from
Nov 16, 2023

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Nov 16, 2023

Removes the hint argument for obtaining the document count in the GET resource for S3Stores.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bcbe290) 87.76% compared to head (7337801) 87.74%.

Files Patch % Lines
src/maggma/api/resource/read_resource.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #888      +/-   ##
==========================================
- Coverage   87.76%   87.74%   -0.03%     
==========================================
  Files          44       44              
  Lines        3614     3615       +1     
==========================================
  Hits         3172     3172              
- Misses        442      443       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 01dee3d into main Nov 16, 2023
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant