Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch s3 kwarg #900

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Patch s3 kwarg #900

merged 5 commits into from
Dec 20, 2023

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Dec 19, 2023

Allow the Indexstore in S3 to be updated through Kwargs

Some programs like atomate1 uses the Kwargs for s3 during the configuration for the store.
As such there is no easy way to pass lesser used kwargs like ssl setting to the index store.
This gives a option for user to do that.

Also removed some of re-definitions of kwargs in the open data object that should just be piped to the S3Store parent class that was caught by codeQL

src/maggma/stores/aws.py Fixed Show fixed Hide fixed
src/maggma/stores/aws.py Fixed Show fixed Hide fixed
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (91163c5) 88.51% compared to head (6f8ef9e) 88.51%.

Files Patch % Lines
src/maggma/stores/aws.py 77.77% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   88.51%   88.51%           
=======================================
  Files          46       46           
  Lines        3779     3779           
=======================================
  Hits         3345     3345           
  Misses        434      434           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury merged commit 5720fa3 into materialsproject:main Dec 20, 2023
9 of 10 checks passed
@rkingsbury
Copy link
Collaborator

Thanks @jmmshn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants