Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linting fixes #901

Merged
merged 2 commits into from
Dec 20, 2023
Merged

linting fixes #901

merged 2 commits into from
Dec 20, 2023

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Dec 19, 2023

updates to run pre-commit run --all-files

updates to run `pre-commit run --all-files`
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (91163c5) 88.51% compared to head (2842448) 88.50%.
Report is 6 commits behind head on main.

Files Patch % Lines
src/maggma/stores/aws.py 33.33% 2 Missing ⚠️
src/maggma/api/query_operator/dynamic.py 80.00% 1 Missing ⚠️
src/maggma/api/resource/read_resource.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #901      +/-   ##
==========================================
- Coverage   88.51%   88.50%   -0.02%     
==========================================
  Files          46       46              
  Lines        3779     3775       -4     
==========================================
- Hits         3345     3341       -4     
  Misses        434      434              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury added pkg Package and repository health housekeeping labels Dec 20, 2023
@rkingsbury rkingsbury merged commit 2f3d741 into materialsproject:main Dec 20, 2023
8 of 10 checks passed
@rkingsbury
Copy link
Collaborator

Thanks for this @jmmshn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping pkg Package and repository health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants