Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get by key default false #910

Merged
merged 2 commits into from Jan 30, 2024
Merged

Make get by key default false #910

merged 2 commits into from Jan 30, 2024

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Jan 30, 2024

Ensure enable_get_by_key is defaulted to False. This default disables the get by key GET endpoint created by ReadOnlyResource.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (91132a4) 82.98% compared to head (0e8db92) 82.98%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   82.98%   82.98%           
=======================================
  Files          46       46           
  Lines        3878     3878           
=======================================
  Hits         3218     3218           
  Misses        660      660           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 5bd33b3 into main Jan 30, 2024
10 checks passed
@munrojm munrojm deleted the get_by_key_default branch January 30, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant