Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix open data store connect and close and address future warnings for pandas #920

Merged
merged 1 commit into from Feb 14, 2024

Conversation

kbuma
Copy link
Contributor

@kbuma kbuma commented Feb 14, 2024

Summary

Adds close method to the stores that have connect and fixes issue with loading data from manifest when connecting.
Also addresses some future deprecation warnings related to DataFrame usage.

Checklist

  • Google format doc strings added.
  • Code linted with ruff. (For guidance in fixing rule violates, see rule list)
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • I have run the tests locally and they passed.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d2bd95e) 81.73% compared to head (70a9541) 81.58%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/maggma/stores/open_data.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   81.73%   81.58%   -0.15%     
==========================================
  Files          46       46              
  Lines        3930     3937       +7     
==========================================
  Hits         3212     3212              
- Misses        718      725       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit ae0e636 into materialsproject:main Feb 14, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants