Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enables using more efficient queries for count, distinct and newer_in #921

Merged

Conversation

kbuma
Copy link
Contributor

@kbuma kbuma commented Feb 16, 2024

Summary

Previously, we enabled more efficient queries for OpenDataStore calls to query, using hints. Extending this for calls to count, distinct and newer_in.

Checklist

  • Google format doc strings added.
  • Code linted with ruff. (For guidance in fixing rule violates, see rule list)
  • Tests added for new features/fixes.
  • I have run the tests locally and they passed.

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (ae0e636) 81.58% compared to head (30446ff) 81.56%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/maggma/stores/open_data.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
- Coverage   81.58%   81.56%   -0.03%     
==========================================
  Files          46       46              
  Lines        3937     3938       +1     
==========================================
  Hits         3212     3212              
- Misses        725      726       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit 53867d9 into materialsproject:main Feb 16, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants