Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to sort query op #944

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Apr 30, 2024

Summary

Adds additional configuration options to the SortQuery query operator including limiting sortable fields and their total number.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 81.26%. Comparing base (bb6868e) to head (45d5ad3).
Report is 1 commits behind head on main.

Files Patch % Lines
src/maggma/api/query_operator/sorting.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   81.28%   81.26%   -0.03%     
==========================================
  Files          46       46              
  Lines        3955     3966      +11     
==========================================
+ Hits         3215     3223       +8     
- Misses        740      743       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@munrojm munrojm merged commit ffd1929 into main Apr 30, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant