Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major update to Linting #162

Merged
merged 8 commits into from Dec 14, 2023
Merged

Major update to Linting #162

merged 8 commits into from Dec 14, 2023

Conversation

jmmshn
Copy link
Collaborator

@jmmshn jmmshn commented Dec 13, 2023

Moved to RUFF

Moved linting to RUFF, and addressed docstring issues from

openjournals/joss-reviews#5941 (comment)

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e6ed8d6) 90.75% compared to head (5c08017) 90.84%.

Files Patch % Lines
pymatgen/analysis/defects/core.py 50.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   90.75%   90.84%   +0.08%     
==========================================
  Files          11       11              
  Lines        2110     2065      -45     
  Branches      403      399       -4     
==========================================
- Hits         1915     1876      -39     
+ Misses        108      102       -6     
  Partials       87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmmshn jmmshn merged commit 564210e into main Dec 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant