New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OrderDisorderedStructureTransformation does not work for oxidation state = 0 #179
Comments
Not sure what the use case is. Ordering doesn't really make sense in this On Tue, Dec 9, 2014 at 12:14 PM, Shyue Ping Ong notifications@github.com
|
Note - I think it would be nice if there was an option to skip the ordering portion (don't do Ewald energies, just return all solutions in an unranked way). The oxidation states would only be required if the Ewald stuff was on. Then such alloys can be ordered more quickly. |
The use case is that enumerate transformation is rather buggy and there are weird cases that it fails and I have to fall back on order disordered trans followed by a structure matching. Moreover, OrderDisordered can order much larger structures than enumerate. |
I also second the option to not do the ewald minimizer. There is a huge current bug in the ewald sum anyway, and I don't trust the energies. It also slows down enumerate quite a fair bit if all I want is to get all possible enumerations (with duplicates) in order disorder. |
@wmdrichards Status of this? |
Is there any plan to address this in the near-term? |
* 'master' of https://github.com/materialsproject/pymatgen: (117 commits) Update reqs Remove hisotry test. If people do not want to implement tests properly, the BDFL will unilaterally remove these changes. Do not parse transformation history. iMore bug fix for entry serialziation. Fix bug in deserialization of ComputedStructureEntry. removed old examples Move Critic2Caller import due to optional dependency / import error Allow no_oxi_state option for OrderedDisorderedTransformation. Fixes materialsproject#179 fix DeformStructureTransformation serialization Add two conf. Remove old docset. try fixing backslashs in regexpattern Fix tasks Updated docs to reflect that Dash docs are now in User Contributed Docsets. Add invoke task to automatically update docs. Update docs Update changelog. Remove useless yaml import causing issues. costdb_elements.csv also missing from setup.py Update docs Fixes materialsproject#1154. ...
E.g., when trying to order alloys, this does not work.
@wmdrichards - pls debug?
The text was updated successfully, but these errors were encountered: