Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderDisorderedStructureTransformation does not work for oxidation state = 0 #179

Closed
shyuep opened this issue Dec 9, 2014 · 6 comments
Closed

Comments

@shyuep
Copy link
Member

shyuep commented Dec 9, 2014

E.g., when trying to order alloys, this does not work.

from pymatgen import Structure, Lattice
from pymatgen.transformations.standard_transformations import OrderDisorderedStructureTransformation

specie = {"Cu0+": 0.5, "Au0+": 0.5}
cuau = Structure.from_spacegroup("Fm-3m", Lattice.cubic(3.677), [specie], [[0, 0, 0]])
trans = OrderDisorderedStructureTransformation()
ss = trans.apply_transformation(cuau, return_ranked_list=100)

@wmdrichards - pls debug?

@wmdrichards
Copy link
Contributor

Not sure what the use case is. Ordering doesn't really make sense in this
case since they all have the same electrostatic energy -- might as well
just do an enumeration.
I agree that its a weird error though - I'll take a look

On Tue, Dec 9, 2014 at 12:14 PM, Shyue Ping Ong notifications@github.com
wrote:

E.g., when trying to order alloys, this does not work.

from pymatgen import Structure, Latticefrom pymatgen.transformations.standard_transformations import OrderDisorderedStructureTransformation

specie = {"Cu0+": 0.5, "Au0+": 0.5}
cuau = Structure.from_spacegroup("Fm-3m", Lattice.cubic(3.677), [specie], [[0, 0, 0]])
trans = OrderDisorderedStructureTransformation()
ss = trans.apply_transformation(cuau, return_ranked_list=100)

@wmdrichards https://github.com/wmdrichards - pls debug?


Reply to this email directly or view it on GitHub
#179.

@computron
Copy link
Member

Note - I think it would be nice if there was an option to skip the ordering portion (don't do Ewald energies, just return all solutions in an unranked way). The oxidation states would only be required if the Ewald stuff was on. Then such alloys can be ordered more quickly.

@shyuep
Copy link
Member Author

shyuep commented Dec 9, 2014

The use case is that enumerate transformation is rather buggy and there are weird cases that it fails and I have to fall back on order disordered trans followed by a structure matching. Moreover, OrderDisordered can order much larger structures than enumerate.

@shyuep
Copy link
Member Author

shyuep commented Dec 9, 2014

I also second the option to not do the ewald minimizer. There is a huge current bug in the ewald sum anyway, and I don't trust the energies. It also slows down enumerate quite a fair bit if all I want is to get all possible enumerations (with duplicates) in order disorder.

@shyuep
Copy link
Member Author

shyuep commented Sep 2, 2015

@wmdrichards Status of this?

@Andrew-S-Rosen
Copy link
Member

Is there any plan to address this in the near-term?

@shyuep shyuep closed this as completed in a7e486f May 28, 2018
gmatteo added a commit to gmatteo/pymatgen that referenced this issue Jun 4, 2018
* 'master' of https://github.com/materialsproject/pymatgen: (117 commits)
  Update reqs
  Remove hisotry test. If people do not want to implement tests properly, the BDFL will unilaterally remove these changes.
  Do not parse transformation history.
  iMore bug fix for entry serialziation.
  Fix bug in deserialization of ComputedStructureEntry.
  removed old examples
  Move Critic2Caller import due to optional dependency / import error
  Allow no_oxi_state option for OrderedDisorderedTransformation. Fixes materialsproject#179
  fix DeformStructureTransformation serialization
  Add two conf.
  Remove old docset.
  try fixing backslashs in regexpattern
  Fix tasks
  Updated docs to reflect that Dash docs are now in User Contributed Docsets. Add invoke task to automatically update docs.
  Update docs
  Update changelog.
  Remove useless yaml import causing issues.
  costdb_elements.csv also missing from setup.py
  Update docs
  Fixes materialsproject#1154.
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants