Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alias VaspInputGenerator for VaspInputSet #3565

Closed
janosh opened this issue Jan 20, 2024 · 0 comments · Fixed by #3566
Closed

Add alias VaspInputGenerator for VaspInputSet #3565

janosh opened this issue Jan 20, 2024 · 0 comments · Fixed by #3566
Labels
io Input/output functionality ux User experience vasp Vienna Ab initio Simulation Package

Comments

@janosh
Copy link
Member

janosh commented Jan 20, 2024 

          My decision is that I have no problems with having an alias called VaspInputGenerator. But VASPInputSet will not be deprecated. Let's be pragmatic - there are many things we probably want to rename. But deprecation of classes/methods creates headaches and unless there is an actual practical benefit, i.e., a large change in functionality or the API, these should not be done.

Originally posted by @shyuep in #3484 (comment)
@janosh janosh added io Input/output functionality vasp Vienna Ab initio Simulation Package ux User experience labels Jan 20, 2024
@janosh janosh changed the title Add alias VaspInputGenerator for VaspInputSet Add alias VaspInputGenerator for VaspInputSet Jan 20, 2024
@janosh janosh mentioned this issue Jan 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
io Input/output functionality ux User experience vasp Vienna Ab initio Simulation Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alias VaspInputSet to VaspInputGenerator materialsproject/pymatgen
1 participant
@janosh